Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: enable new serdes format of DataTypeString #9742

Merged
merged 2 commits into from
Dec 31, 2024
Merged

*: enable new serdes format of DataTypeString #9742

merged 2 commits into from
Dec 31, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Dec 25, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9673

What is changed and how it works?

Enable serdes format of DataTypeString that introducing by #9608.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Enable new serialization method of string by default to improve the table scan performance

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 25, 2024
@JinheLin JinheLin changed the title *: enable new serdes format of DataTypeString DNM: *: enable new serdes format of DataTypeString Dec 26, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 30, 2024
@JinheLin JinheLin changed the title DNM: *: enable new serdes format of DataTypeString *: enable new serdes format of DataTypeString Dec 30, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 30, 2024
JaySon-Huang
JaySon-Huang approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 31, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-30 08:44:00.295388569 +0000 UTC m=+339975.651393109: ☑️ agreed by Lloyd-Pottiger.
  • 2024-12-31 06:52:40.107901875 +0000 UTC m=+419695.463906410: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 0fd3441 into pingcap:master Dec 31, 2024
5 checks passed
yibin87 pushed a commit to yibin87/tiflash that referenced this pull request Jan 3, 2025
@JinheLin @JaySon-Huang @yibin87
*: enable new serdes format of DataTypeString (pingcap#9742)
ed6c219 
close pingcap#9673

Co-authored-by: JaySon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance deserialization performance of short string.
3 participants
@JinheLin @JaySon-Huang @Lloyd-Pottiger